Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including Participant.hpp instead of precice.hpp - By design or outdated? #194

Open
MakisH opened this issue Feb 8, 2024 · 1 comment
Open

Comments

@MakisH
Copy link
Member

MakisH commented Feb 8, 2024

cdef extern from "precice/Participant.hpp" namespace "precice":

The precice/Participant.hpp is the renamed precice/SolverInterface.hpp. However, we now also have precice/precice.hpp, which is meant to be the central header to include. This currently contains also Version.h, span.hpp, and could in the future contain more (or less).

This is not a problem, especially since it works at the moment, but it sticks out in the architecture picture. Changing it should have no functional effect anywhere.

Bindings

@IshaanDesai
Copy link
Member

This is outdated and something I forgot to update before releasing the bindings. I have opened a draft pull request to do this: #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants