Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also provide a steady-state case? #7

Open
BenjaminRodenberg opened this issue Feb 24, 2022 · 2 comments
Open

Also provide a steady-state case? #7

BenjaminRodenberg opened this issue Feb 24, 2022 · 2 comments
Milestone

Comments

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Feb 24, 2022

An example case is flow-over-heated-plate-steady-state, but we could also prepare a variant of the partitioned heat equation for steady state.

@BenjaminRodenberg BenjaminRodenberg added this to the v0.1.0 milestone Feb 24, 2022
@arvedes
Copy link
Contributor

arvedes commented Mar 3, 2022

I have a working flow-over heated plate steady-state example now: https://github.com/nemocrys/dolfinx-openfoam/tree/main/steady_state (I still want to improve the FEniCS participant a bit). It uses a slightly different setup than https://precice.org/tutorials-flow-over-heated-plate-steady-state.html, it is all in 2D - similar to the transient case.
image
How shall we proceed with the OpenFOAM setup? Add it to this repository until there is another solution?

@BenjaminRodenberg
Copy link
Member Author

That's great and it looks like we are almost there. Two main points I see:

  • Why is the setup different? We try to use identical setups for all solver combinations to make them easier to compare. If possible, we should try to use the OpenFOAM setup from the tutorials. Is this possible? Then we can (just like for the other cases) store the FEniCS-X solver in this repository as long as the adapter is under development. As soon as we have a stable API we can move everything to the tutorials repository.
  • We should make sure that the results for OpenFOAM-OpenFOAM and OpenFOAM-FEniCS-X are identical. From our reference paper we already have some experience with comparing results for the non-steady case. I think we don't have to change a lot here. You can find the script for comparison here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants