Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable diff mode between data sets #170

Open
davidscn opened this issue Feb 9, 2023 · 2 comments
Open

Enable diff mode between data sets #170

davidscn opened this issue Feb 9, 2023 · 2 comments
Labels
good first issue Starter projects for newcomer

Comments

@davidscn
Copy link
Member

davidscn commented Feb 9, 2023

We have the so-called 'diff'-mode in precice-aste-evaluate in order to compute error metrics on our output mesh. The diff mode takes as input arguments the diffdata (data used for the difference calculation) and a function in order to generate reference data. However, computing the difference between two data fields is not possible. We should extend the current CLI to also accept a second ('reference') data field and compute the error between these two data fields instead of an analytic function.

@davidscn
Copy link
Member Author

davidscn commented Jul 18, 2024

A bit of an open question is, how the user interface then looks like. Currently, we have

The --diff flag calculates the difference between "--diffdata" and the specifiedfunction "--function"

precice-aste-evaluate -m map_nn.vtk -f "franke3d" -d difference --diffdata "InterpolatedData" --diff

Here, the diffdata is already the data we use to compute the difference and difference is the name of the data we store on the mesh file. We could make the function argument optional and enable two 'diffdata':

precice-aste-evaluate -m map_nn.vtk -d difference --diffdata "InterpolatedData" "ReferenceData" --diff

@uekerman
Copy link
Member

Alternative could be an optional --refData?

@davidscn davidscn added the good first issue Starter projects for newcomer label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Starter projects for newcomer
Projects
None yet
Development

No branches or pull requests

2 participants