Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

almalinux image does not have git #40

Open
devongovett opened this issue Nov 4, 2024 · 2 comments
Open

almalinux image does not have git #40

devongovett opened this issue Nov 4, 2024 · 2 comments
Labels
pull request welcome A pull request is welcome

Comments

@devongovett
Copy link

This makes the checkout action fail immediately. https://github.com/parcel-bundler/watcher/actions/runs/11658766811/job/32458292494

I was able to manually install it for now but would be nice to have in the image by default.

@vweevers
Copy link
Member

vweevers commented Nov 4, 2024

For the main use case of prebuildify-cross we don't need git but I see some other images do have git (I don't remember why) and it's small so a PR is welcome to add it.

@vweevers vweevers added the pull request welcome A pull request is welcome label Nov 4, 2024
@vweevers
Copy link
Member

vweevers commented Nov 4, 2024

That's an interesting approach in your workflow btw, setting the container of a job. Might remove the need for prebuildify-cross, I'll need to try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request welcome A pull request is welcome
Projects
None yet
Development

No branches or pull requests

2 participants