Huaweiads: Remove empty image assets from response #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
Code coverage summaryNote:
huaweiadsRefer here for heat map coverage report |
SyntaxNode
changed the title
Comment on lines
+1181
to
+1183
| if len(content.MetaData.ImageInfo) == imgIndex && asset.Img.Type == native1.ImageAssetTypeMain { | ||
| continue | ||
| } |
There was a problem hiding this comment.
@ahmetfaruk59 could you help to explain how this change bind the number of main image objects from huaweiads instead of all main image objects in the request
There was a problem hiding this comment.
Hi @onkarvhanumante. Previously all assets for main image type in the request were included in the response. Now only the main images returned from the huaweiads service are returned as a response. in the mentioned condition block, imgIndex is for making sure that all returned ads from huaweiads are binded to response and the type of the asset is main image type3. after all image assets from the service is binded then "continue" for other image main assets in the request
Previous:
request: "{assets:[
{required:0,title:{len:90}},
{required:0,img:{type:1,w:20,wmin:20,h:20,hmin:20}},
{required:0,img:{type:3,w:300,wmin:300,h:250,hmin:250}},
{required:0,img:{type:3,w:640,wmin:640,h:360,hmin:360}},
{required:0,img:{type:3,w:1312,wmin:1080,h:607,hmin:768}},
...
...
]}
response
assets:[
{id:0,title:{text:"Jewel Blast Legend",len:18}},
{id:2,img:{type:1,url:"image1.png",w:20,h:20}},
{id:2,img:{type:3,url:"image2.png",w:1080,h:607}},
{id:3,img:{type:3,url: " " ,w:300,h:250}},
{id:4,img:{type:3,url: " " ,w:320,h:250}},
{id:5,img:{type:3,url: "" ,w:1312,h:768}},
.
.
.
]
onkarvhanumante
approved these changes
Nov 23, 2023
Sonali-More-Xandr
approved these changes
Nov 23, 2023
SuprPhatAnon
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind the number of main image objects from huaweiads instead of all main image objects in the request