Yieldmo: Get bid type from bid.ext.mediatype in bid response #3295

ym-prasanth · 2023-11-14T15:14:36Z

For Yieldmo bidder, Bid.ext now includes a field called mediatype which represents the bid type. This PR includes the changes necessary to retrieve this new field and pass it upstream as the bid type.

…ter (#1)

adapters/yieldmo/yieldmo.go

github-actions · 2023-11-14T15:15:28Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 40f48df

yieldmo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:37:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:50:	makeRequest		70.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:76:	preprocess		83.3%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:118:	MakeBids		70.6%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:160:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:168:	getMediaTypeForImp	75.0%
total:									(statements)		79.3%

adapters/yieldmo/yieldmo.go

github-actions · 2023-11-16T15:38:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 14ebf6b

yieldmo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:37:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:50:	makeRequest		70.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:76:	preprocess		83.3%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:118:	MakeBids		70.6%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:160:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:168:	getMediaTypeForImp	75.0%
total:									(statements)		79.3%

adapters/yieldmo/yieldmo.go

github-actions · 2023-11-16T16:21:35Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c68be34

yieldmo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:37:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:50:	makeRequest		70.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:76:	preprocess		83.3%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:118:	MakeBids		70.6%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:160:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:168:	getMediaTypeForImp	62.5%
total:									(statements)		77.4%

github-actions · 2023-11-16T20:25:51Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d49eaa2

yieldmo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:37:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:50:	makeRequest		70.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:76:	preprocess		83.3%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:118:	MakeBids		70.6%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:160:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:168:	getMediaTypeForImp	63.6%
total:									(statements)		76.9%

This reverts commit d49eaa2.

github-actions · 2023-11-27T14:33:14Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f3b4a5c

yieldmo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:37:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:50:	makeRequest		70.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:76:	preprocess		83.3%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:118:	MakeBids		70.6%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:160:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:168:	getMediaTypeForImp	62.5%
total:									(statements)		77.4%

github-actions · 2023-11-27T14:39:05Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 775d441

yieldmo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:37:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:50:	makeRequest		70.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:76:	preprocess		83.3%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:118:	MakeBids		70.6%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:160:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/yieldmo/yieldmo.go:168:	getMediaTypeForImp	62.5%
total:									(statements)		77.4%

ym-prasanth · 2023-11-29T21:07:04Z

@onkarvhanumante When will this PR get merged to master?

onkarvhanumante · 2023-11-30T10:41:19Z

@onkarvhanumante When will this PR get merged to master?

@ym-prasanth Thanks for keeping paitence with us. PR will get merge after second approval.

gargcreation1992

g2g.
Please issue a patch to populate Mtype field as discussed in this PR.

…3295)

ym-prasanth and others added 3 commits November 8, 2023 12:20

Added support for specifying media type per impression

a2001bd

AS-4133 Support media type per impression - Golang prebid server adap…

3aa6fc8

…ter (#1)

Merge branch 'prebid:master' into master

40f48df

github-actions bot reviewed Nov 14, 2023

View reviewed changes

adapters/yieldmo/yieldmo.go Outdated Show resolved Hide resolved

bsardo changed the title ~~Retrieve bid type from bid.ext.mediatype in Yieldmo bid response~~ Yieldmo: Get bid type from bid.ext.mediatype in bid response Nov 14, 2023

Sonali-More-Xandr assigned onkarvhanumante and Sonali-More-Xandr Nov 15, 2023

Merge branch 'prebid:master' into master

14ebf6b

github-actions bot reviewed Nov 16, 2023

View reviewed changes

adapters/yieldmo/yieldmo.go Outdated Show resolved Hide resolved

CR feedback. Return explicit bid type. (#2)

c68be34

github-actions bot reviewed Nov 16, 2023

View reviewed changes

adapters/yieldmo/yieldmo.go Show resolved Hide resolved

CR feedback 2. Set media type in the bid response (#3)

d49eaa2

prebid deleted a comment from github-actions bot Nov 20, 2023

onkarvhanumante assigned gargcreation1992 and unassigned Sonali-More-Xandr Nov 27, 2023

Revert "CR feedback 2. Set media type in the bid response (#3)" (#4)

f3b4a5c

This reverts commit d49eaa2.

Merge branch 'prebid:master' into master

775d441

prebid deleted a comment from github-actions bot Nov 27, 2023

onkarvhanumante approved these changes Nov 28, 2023

View reviewed changes

gargcreation1992 approved these changes Nov 30, 2023

View reviewed changes

gargcreation1992 merged commit a6dea2f into prebid:master Nov 30, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Nov 30, 2023

Port PR from PBS-Go: Yieldmo: Get bid type from bid.ext.mediatype in bid response prebid/prebid-server-java#2805

Closed

SuprPhatAnon pushed a commit to GiftConnect/prebid-server that referenced this pull request Dec 7, 2023

Yieldmo: Get bid type from bid.ext.mediatype in bid response (prebid#…

bcb5f94

…3295)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yieldmo: Get bid type from bid.ext.mediatype in bid response #3295

Yieldmo: Get bid type from bid.ext.mediatype in bid response #3295

ym-prasanth commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 27, 2023

github-actions bot commented Nov 27, 2023

ym-prasanth commented Nov 29, 2023

onkarvhanumante commented Nov 30, 2023

gargcreation1992 left a comment

Yieldmo: Get bid type from bid.ext.mediatype in bid response #3295

Yieldmo: Get bid type from bid.ext.mediatype in bid response #3295

Conversation

ym-prasanth commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

Code coverage summary

yieldmo

github-actions bot commented Nov 16, 2023

Code coverage summary

yieldmo

github-actions bot commented Nov 16, 2023

Code coverage summary

yieldmo

github-actions bot commented Nov 16, 2023

Code coverage summary

yieldmo

github-actions bot commented Nov 27, 2023

Code coverage summary

yieldmo

github-actions bot commented Nov 27, 2023

Code coverage summary

yieldmo

ym-prasanth commented Nov 29, 2023

onkarvhanumante commented Nov 30, 2023

gargcreation1992 left a comment

Choose a reason for hiding this comment