Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook_impl_code should be available to a module in the ModuleInvocationContext #4035

Open
scr-oath opened this issue Nov 4, 2024 · 0 comments · May be fixed by #4036
Open

hook_impl_code should be available to a module in the ModuleInvocationContext #4035

scr-oath opened this issue Nov 4, 2024 · 0 comments · May be fixed by #4036

Comments

@scr-oath
Copy link
Contributor

scr-oath commented Nov 4, 2024

There are reasons to desire invoking the same hook twice in two groups of the same stage - namely, if there is any I/O that can be started in one group and joined/Wait'ed in the 2nd - then the I/O time can overlap/be parallel with the CPU time of the first group.

While there are techniques such as putting a counter into an entry of the ModuleInvocationContext.ModuleContext, it seems like a missed opportunity to just use the configured hook_impl_code - if this were passed in the ModuleInvocationContext then the module could easily differentiate which of the two invocations were being invoked definitively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant