Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for same ad size being served several times on the same page #42

Open
dshore opened this issue Feb 25, 2021 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@dshore
Copy link
Collaborator

dshore commented Feb 25, 2021

Description

I would like to be able to do orders by size where each line item contains e.g. only 1 size. In this example I would like to have many creatives but all are for one size only.

@dshore dshore added the enhancement New feature or request label Feb 25, 2021
@dshore
Copy link
Collaborator Author

dshore commented Feb 25, 2021

Proposed Enhancement

Support configurations when "size_override" is False that allows user to specify the number of copies of the creative desired, eg:

creative: # at least one of the following types is required {video, banner}
  name: "Prebid {{ bidder_name }}-{{ media_type }}"
  banner:
    # safe_frame: False # optional: defaults to True
    size_override: False # optional: defaults to True with a 1x1 creative
    copies: 5 # new field
    sizes: # list
      - height: 480
        width: 640
    snippet: |
      <script src = "https://..."></script>
        <script>
          ...
        </script>

@Zer0Divis0r
Copy link

@dshore , can you please clarify: "size_override: False" and "copies: 5" does exactly what? If I specify 10 sizes, and I have 450 line items, how many LICA objets will it create?
Same question is for "size_override: True", 10 sizes and 450 line items creates 4500 LICA objects, as far as I see in the other issue discussing the size_override feature it was suppsed to create to more then 5 LICAs, but I see that it creates a LICA per line item per size's creative.

@dshore
Copy link
Collaborator Author

dshore commented Oct 5, 2021

This option has copies in sizes array - agreed by committee that this is preferable:

creative: # at least one of the following types is required {video, banner}
  name: "Prebid {{ bidder_name }}-{{ media_type }}"
  banner:
    # safe_frame: False # optional: defaults to True
    size_override: False # optional: defaults to True with a 1x1 creative
    sizes: # list
      - height: 480
        width: 640
        copies: 5
     - height: 300
       width: 250
       copies: 3
    snippet: |
      <script src = "https://..."></script>
        <script>
          ...
        </script>

@shuaibjewon-qz
Copy link

shuaibjewon-qz commented Sep 7, 2023

Hi @dshore

Reviving this. I recently implemented duplicating creatives for banner. Made a draft PR with my changes. Happy to make this more granular (specify number of copies by size) and get this merged if this feature is still desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants