Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flex-basis: fill-available(stretch) #1519

Open
yisibl opened this issue Jul 17, 2024 · 6 comments
Open

Support flex-basis: fill-available(stretch) #1519

yisibl opened this issue Jul 17, 2024 · 6 comments

Comments

@yisibl
Copy link
Member

yisibl commented Jul 17, 2024

TODO

Input

.foo {
   flex-basis: stretch;
}

Expected

Note: Chrome does not implement flex-basis: -webkit-fill-available!

.example {
   flex-basis: -webkit-fill-available; /* Safari */
   flex-basis: -moz-available;
   flex-basis: stretch;
}
@ai
Copy link
Member

ai commented Jul 22, 2024

Mention me in the comment when you will finish the issue.

@yisibl
Copy link
Member Author

yisibl commented Sep 24, 2024

Sorry for the delay, let's wait for Chrome to implement the stretch keyword before deciding on the details of the Autoprefixer tweak.
https://groups.google.com/a/chromium.org/g/blink-dev/c/fxGpXGV0hYc/m/HOSYpsfiBgAJ

@yisibl
Copy link
Member Author

yisibl commented Sep 24, 2024

With Chrome and Firefox on the verge of implementing the stretch keyword without a prefix, I think it's time to ditch the fill and fill-available keywords, they're history.

Can we add a warning? And then remove it completely after a certain release.

isStretch() {
return (
this.name === 'stretch' ||
this.name === 'fill' ||
this.name === 'fill-available'
)
}

@ai
Copy link
Member

ai commented Sep 25, 2024

What warning do you suggest?

@yisibl
Copy link
Member Author

yisibl commented Oct 10, 2024

Warning: the fill or fill-available keywords have been deprecated by the specification in favor of stretch.
Autoprefixer will drop support for these two keywords in a future release.

@ai
Copy link
Member

ai commented Oct 21, 2024

Can you send PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants