Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to cancel a deployment (for now) #2498

Open
m-- opened this issue Dec 17, 2024 · 1 comment
Open

Remove ability to cancel a deployment (for now) #2498

m-- opened this issue Dec 17, 2024 · 1 comment
Milestone

Comments

@m--
Copy link
Collaborator

m-- commented Dec 17, 2024

We added an attempt to support cancelling deployments in progress, but we need changes on Connect to support it fully. #304 is the issue to fully support this functionality, but in the mean time we should remove what appears to be support for cancellation in Publisher (which doesn't fully work).

Removing this would solve #2179

@dotNomad
Copy link
Collaborator

dotNomad commented Dec 19, 2024

Noting here that we still need the ability to dismiss an in-progress deploy, if we still disable the deploy button while something is in progress. This will prevent a regression of #2057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants