Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show patches made in remote files #7

Open
porsager opened this issue Oct 22, 2017 · 5 comments
Open

Show patches made in remote files #7

porsager opened this issue Oct 22, 2017 · 5 comments

Comments

@porsager
Copy link
Owner

@pygy suggested it would be great to show patches made in remote files.

The CodeMirror merge plugin might be an easy way to achieve this.

@pygy
Copy link
Contributor

pygy commented Apr 2, 2018

As mentioned in #42, it would be nice to show that the deps have been tampered with, even if we can't see what changed (maybe italicize the name and add a *?)

@porsager
Copy link
Owner Author

porsager commented Apr 2, 2018

I tried with * and italic, but it felt more like it represented "Not saved". I also tried various icons, but I think the following communicates the situation best.. What do you think?
screen shot 2018-04-02 at 11 03 31

@osban
Copy link

osban commented Apr 2, 2018

Looks good to me. Maybe if the number of tabs, and/or the width of the window, become such that a shorter version would become useful, you could shorten it to something like (*)?

porsager added a commit that referenced this issue Apr 2, 2018
@pygy
Copy link
Contributor

pygy commented Apr 2, 2018

What about (*) by default and (modified) when the tab is active?

@osban
Copy link

osban commented Apr 2, 2018

"I'm with you fellas" ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants