-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct cumulative_gas_used calculation #1559
Conversation
Well, something is broken in the test suite it looks like... |
Is the |
Yes, this is also a problem |
According to the next: frontier/frame/ethereum/src/lib.rs Lines 678 to 706 in db4411c
Each transaction receipt stores already |
See #602 |
Right, but then, should we rename the struct field accordingly to avoid further confusion? |
No check for the block_gas_limit; the block_gas_limit is a fixed value derived from the block_max_weight. In fact, we convert the transaction gas to the transaction weight and ensure all transaction weights are less than the block max weight. |
Closes #1558.