From e9a4bef6ef6f706ead390f28c5e5b677e2caf256 Mon Sep 17 00:00:00 2001 From: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com> Date: Fri, 30 Aug 2024 13:50:14 +0200 Subject: [PATCH] move comment above --- src/Makevars.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Makevars.in b/src/Makevars.in index c0ea93f75..5ccb0791f 100644 --- a/src/Makevars.in +++ b/src/Makevars.in @@ -14,6 +14,9 @@ $(SHLIB): $(STATLIB) CARGOTMP = $(CURDIR)/.cargo +# -z noexecstack added to avoid following error on Ubuntu: +# /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /usr/local/lib/R/site-library/polars/libs/polars.so)` +# https://stackoverflow.com/questions/73435637/how-can-i-fix-usr-bin-ld-warning-trap-o-missing-note-gnu-stack-section-imp/73468271#73468271 $(STATLIB): if [ -f "$(CURDIR)/../tools/$(LIBNAME)" ]; then \ mkdir -p "$(LIBDIR)" ; \ @@ -25,9 +28,6 @@ $(STATLIB): export CARGO_BUILD_JOBS=2; \ fi && \ export PATH="$(PATH):$(HOME)/.cargo/bin" && \ - # -z noexecstack added to avoid following error on Ubuntu: - # /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /usr/local/lib/R/site-library/polars/libs/polars.so)` - # https://stackoverflow.com/questions/73435637/how-can-i-fix-usr-bin-ld-warning-trap-o-missing-note-gnu-stack-section-imp/73468271#73468271 cargo build --lib --manifest-path="$(CURDIR)/rust/Cargo.toml" --target-dir "$(TARGET_DIR)" --target="$(TARGET)" \ --profile="$(LIBR_POLARS_PROFILE)" --features="$(LIBR_POLARS_FEATURES)" -z noexecstack