Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping and close to each other segments #61

Open
tomasklaen opened this issue Sep 23, 2022 · 1 comment
Open

Overlapping and close to each other segments #61

tomasklaen opened this issue Sep 23, 2022 · 1 comment

Comments

@tomasklaen
Copy link

Example video: https://www.youtube.com/watch?v=Npu7jkJk5nM

There are 2 overlapping segments, one at the beginning, and one at the end. To illustrate:

[===A===]
       [===B===]

When playback arrives at the beginning of A, it skips to end of A instead of end of B.

When fixing this, please don't just detect overlaps, but also segments that are closer than let's say half a second to each other, and skip past that gap as well.

@alopatindev
Copy link

Looks like overlapping segments issues exist in original browser extension as well (1, 2, 3)

But could this specific issue reproduce due to ignored categories? For me these settings give (more) satisfying behavior for this video (it jumps to 1:25 after reaching 0:56)

# ~/.config/mpv/script-opts/sponsorblock.conf
skip_categories=sponsor,intro,outro,interaction,selfpromo,preview,music_offtopic,filler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants