Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write data to a standard writable directory for cache data #16

Open
pacien opened this issue Jul 6, 2020 · 1 comment · May be fixed by #17
Open

Write data to a standard writable directory for cache data #16

pacien opened this issue Jul 6, 2020 · 1 comment · May be fixed by #17

Comments

@pacien
Copy link

pacien commented Jul 6, 2020 •
edited
Loading

Currently, the script attempts to write the user ID and the sponsorblock DB within the "sponsorblock_shared" directory. However, the directory in which the script is located isn't always writable (for example when the script is installed through a system package manager and used with mpv --scripts=[path to script]).

A more standard location would perhaps be $XDG_CACHE_HOME/mpv/scripts/sponsorblock/sponsorblock.{txt,db} on Linux. I'm not sure whether similar standard paths are defined on other platforms though.

NixOS/nixpkgs#92507 (comment)
@po5
Copy link
Owner

po5 commented Jul 6, 2020

PRs welcome, requirement is that the location should available on all systems mpv runs on.

@pacien pacien linked a pull request Jul 7, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use XDG_DATA_HOME and XDG_CACHE_HOME if defined for UID and DB pacien/mpv_sponsorblock
2 participants
@pacien @po5