Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release doesn't appear to respect the "remove padding" setting #5279

Closed
1 of 9 tasks
lordneeko opened this issue Oct 3, 2024 · 2 comments
Closed
1 of 9 tasks
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs

Comments

@lordneeko
Copy link

Disclaimer

Yes

Sample

https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-script-editor

Contributor(s)

Wobba

What happened?

I noticed with the latest release of the modern script editor that my script web parts even when I have selected for it to remove padding, it does not seem to respect that. The web parts are still taking up all of their space when I publish the page.

Steps to reproduce

  1. Edit page
  2. Add modern script editor Web part
  3. Turn on "remove padding"
  4. Save draft or publish
  5. Notice that the entire script part's size is being blocked out on the page

Expected behavior

When padding is removed. I expect the page to not have any padding around a script web part that doesn't have size. For example, I have code that is just JavaScript and has no actual size on the HTML page yet it is still taking up the same size as the block for the web part. This is only happening on the Chrome browser. It does not happen on Edge browser.

Target SharePoint environment

SharePoint Online

Developer environment

None

Browsers

  • Internet Explorer
  • Microsoft Edge
  • Google Chrome
  • FireFox
  • Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

What version of Node.js is currently installed on your workstation?

NA

What version of Node.js is required by the sample?

NA

Paste the results of SPFx doctor

NA

Additional environment details

No response

@lordneeko lordneeko added the type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs label Oct 3, 2024
@lordneeko
Copy link
Author

I just noticed the issue only exists when you "save as draft" not when you publish. Closing

@Adam-it
Copy link
Member

Adam-it commented Oct 13, 2024

@lordneeko thanks for the heads up and the double check. You Rock 👏👏🤩

@Adam-it Adam-it closed this as completed Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs
Projects
None yet
Development

No branches or pull requests

2 participants