Fall and step sounds are played multiple times for players in some cases

[Nerahikada]

Issue description

When the player enters the water and lands on the ground, an extra step sound is played.

OS and versions

• PocketMine-MP: 4.0.0-BETA2 (git hash: 26e3280)
• PHP: 8.0.10
• Using JIT: no
• Server OS: win
• Game version: Win10

Plugins

[17:01:13.323] [Server thread/INFO]: Plugins (0):

Crashdump, backtrace or other files

vanilla:

Minecraft.2021-09-11.17-57-03.mp4

pmmp:

Minecraft.2021-09-11.17-50-22.mp4

[inxomnyaa]

https://youtu.be/lNGLh7eGij0 confirmed
It also appears to duplicate sounds when walking/sprinting

[dktapps]

This bug occurs because the server registers the player as "on ground" before they actually touch the ground. There may be multiple "within range of ground" ticks while falling. This is (was?) necessary due to the margin of error that can appear in positions, particularly when jumping - the server may not actually ever see them touch the ground. I've yet to verify whether this is still a problem with PlayerAuthInputPacket or not.

[dktapps]

Related to #6547