Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning due to use of deprecated default_features #598

Closed
andrewdavidmackenzie opened this issue Jun 19, 2024 · 6 comments
Closed

Warning due to use of deprecated default_features #598

andrewdavidmackenzie opened this issue Jun 19, 2024 · 6 comments

Comments

@andrewdavidmackenzie
Copy link
Contributor

In my build I noticed this, so I thought I'd mention it:

cargo build --features "gui"
warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition
(in the `plotters` dependency)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s
@Philippe-Cholet
Copy link

This should be closed thanks to #604.

@andrewdavidmackenzie
Copy link
Contributor Author

I think still no published release including this change?

@AaronErhardt
Copy link
Member

I think still no published release including this change?

The last release is from September, the PR merged in July, so actually this is published by now.

@andrewdavidmackenzie
Copy link
Contributor Author

crates.io has 0.3.7 as the latest release:
https://crates.io/crates/plotters
uploaded on September 8th.

Pr was merged on July 1st
#604

my project resolves 0.3 to 0.3.7 as would be expected
https://github.com/andrewdavidmackenzie/pigg/blob/master/Cargo.lock#L4397

but I am still getting this warning in my builds (even after a cargo update)

warning: /Users/andrew/workspace/pigg/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition
(in the `plotters` dependency)

So, I am not sure what is wrong, maybe the version with the PR was not the one uploaded to crates.io?

@AaronErhardt
Copy link
Member

So, I am not sure what is wrong, maybe the version with the PR was not the one uploaded to crates.io?

Very unlikely. I just do the release from the master branch which contains the fix.

Looking at the source at crates.io, it becomes obvious that there is no single instance of default_features there, just like in the master branch. I have no idea what causes the warning for you, maybe clean, update and compile again?

@andrewdavidmackenzie
Copy link
Contributor Author

clean fixed it, so thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants