Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inferring return value of user-defined routes #238

Open
rpkyle opened this issue Oct 30, 2020 · 0 comments
Open

Add support for inferring return value of user-defined routes #238

rpkyle opened this issue Oct 30, 2020 · 0 comments

Comments

@rpkyle
Copy link
Contributor

rpkyle commented Oct 30, 2020

As mentioned in https://github.com/plotly/dash-docs/pull/964#discussion_r490372101, users may find it confusing that route handlers added via app$server_route should return TRUE or FALSE depending on whether routr should continue traversing the route stack.

It would be trivial and potentially less confusing to infer TRUE if the function does not return TRUE or FALSE. We should consider adding a check in case users elect to omit TRUE/FALSE, and modifying the Dash for R documentation here once this feature is implemented.

@alexcjohnson @Marc-Andre-Rivet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant