Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feed picker view (UI only) #103 #1706

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

bryanmontz
Copy link
Contributor

Issues covered

https://github.com/verse-pbc/issues/issues/103

Description

  1. Changes the Feed view's navigation titleView from the words "Accounts I Follow" to the Nos logo.
  2. Adds the feed picker view, which is a horizontally scrolling list of buttons to select the feed the user wants to see. This is currently non-functional and includes only "Following" and all the user's relays.

Designs:
https://www.figma.com/design/9U8xJlfBllvblDVN2FAFK0/Nos---Work-Sheets?node-id=159-3686&m=dev

To be added in a following PR:

  1. lists
  2. actually make the contents of the feed change based on selection

Screenshots/Video

Before After
feed-picker-before feed-picker-after

Compare the designs (left) and the implementation in the simulator (right):
image

Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I noticed that the selected feed name "pops" a little when you tap on it because the text is bold and the padding increases a bit. I think a little animation on change would be a nice touch.

@bryanmontz
Copy link
Contributor Author

Looks good! I noticed that the selected feed name "pops" a little when you tap on it because the text is bold and the padding increases a bit. I think a little animation on change would be a nice touch.

I had to disable animations because the words themselves were animating from regular to bold, and it looked really strange. I can mess with it again once we get to a polishing stage with the feature.

@bryanmontz bryanmontz merged commit 7a8ac3b into feature/lists-ui Dec 24, 2024
4 checks passed
@bryanmontz bryanmontz deleted the bdm/103-list-picker branch December 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants