Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No reviewers returned from the API endoint users/reviewers #10739

Open
bozana opened this issue Dec 19, 2024 · 1 comment
Open

No reviewers returned from the API endoint users/reviewers #10739

bozana opened this issue Dec 19, 2024 · 1 comment
Assignees
@bozana @pkp-dev-workflow
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.4.0-9

Comments

@bozana
Copy link
Collaborator

bozana commented Dec 19, 2024 •
edited
Loading

S. https://forum.pkp.sfu.ca/t/rest-api-reviewers-list/93608

The API call api/v1/users/reviewers without the parameter 'reviewStage' returns no items, because it is not checked if the parameter 'reviewStage' exists before applying the filter by workflow stage in this line: https://github.com/pkp/pkp-lib/blob/stable-3_4_0/api/v1/users/PKPUserHandler.php#L224.

In 3.3 the function filterByReviewStage() takes only one stage. This seems to be changed in 3.4, so that the function filterByWorkflowStageIds() takes an array, however the parameter is still only one stage and not an array.

PRs:
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Dec 19, 2024
@bozana bozana added this to the 3.4.0-9 milestone Dec 19, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Dec 19, 2024
@bozana
pkp#10739 getReviewers(): check if param reviewStage exists for filte…
09a3726 
…ring by workflow stage
bozana added a commit to bozana/ojs that referenced this issue Dec 19, 2024
@bozana
pkp/pkp-lib#10739 submodule update ##bozana/10739-3_4_0##
d53d0d7
This was referenced Dec 19, 2024
Open
Open
@bozana
Copy link
Collaborator Author

bozana commented Dec 19, 2024

Hi @ewhanson, could you please review the fix above?
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

@pkp-dev-workflow pkp-dev-workflow

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.4.0-9
Development

No branches or pull requests
2 participants
@bozana @pkp-dev-workflow