Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5 - Participants Login As option should not be available to all users #10731

Open
Tribunal33 opened this issue Dec 18, 2024 · 3 comments
Open
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone

Comments

@Tribunal33
Copy link

Describe the bug
Currently you can access the Login As feature when you are logged in as a user role that would not normally have access to this feature. Additionally for consistency the Login As option should not be available for a person who already is logged in similar to how settings user's & roles Login As function works.

Precondidtion : Using default dataset. Can use any lower level participant of a submission.

To Reproduce
Steps to reproduce the behavior:

  1. Go to VM and login the normal way with user "mfritz"
  2. In the active submission list select View on submission ID 6 - Phillips — Investigating the Shared...
  3. In the particpants list select the 3 dots on either participant (Daniel Barnes)
  4. Observe the option table

Actual: The Login As option is available (See screenshot)
Expected: The login option should only be available to those with access like Journal Managers, Journal Editors, or Admin

What application are you using?
OJS, OMP or OPS version X.X.X

Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.
Image

Similar to the settings if you are already logged in as a particular user and that user is a participant then the login As option should be hidden.
Example would be to normally log in as Daniel Barnes and then find a submission that they were a participant of and click the three dots. This should be hidden similar to how it gets hidden in the settings user & roles section.
Image

@Tribunal33 Tribunal33 added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Dec 18, 2024
@Tribunal33 Tribunal33 added this to the 3.5.0 LTS milestone Dec 18, 2024
@jardakotesovec
Copy link
Contributor

@Tribunal33 Yeah, thats being worked on - #10290 . Participant UI is part of the new workflow page, where every area is covered by subissue in #10598 . Therefore there will be dedicated subissue for Participants once thats ready for testing.

@Tribunal33
Copy link
Author

Added 10290 as a parent. Thanks @jardakotesovec .

@jardakotesovec
Copy link
Contributor

@Tribunal33 Created placeholder subissue #10742 and used it as parent, as that issue is covering that area being finished including the frontend integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Development

No branches or pull requests

2 participants