Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting notification link by author for submission dashboard redirects to root #10706

Open
Tribunal33 opened this issue Dec 14, 2024 · 1 comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Milestone

Comments

@Tribunal33
Copy link

Describe the bug
Notification for "Your submission has been reviewed…" has a dynamic link to a “Submission Dashboard” that reference old controllers. Should be updated or maybe there is a typo? I see a network redirect 302 and then a missing } in console (see screenshot)
from emails.po file -> All references have this line of code <a href="{$authorSubmissionUrl}">submission dashboard

  • search in the code for this reference {$authorSubmissionUrl} <--- lots of references.

Preconditions:
Use default dataset, user is Lisa Kumiega login but I think it would be for any notification template that has this link. Was found using a review stage submission that is needing revisions. Notification message is "Your submission has been reviewed and we encourage you to submit revisions"

To Reproduce
Steps to reproduce the behavior:

  1. Be logged in as Lisa Kumiega
  2. Select View on the Active submission (ID 13 Kumiega)
  3. Under the notifications section links select "Your submission has been reviewed and we encourage...."
  4. Select the link "submission dashboard"

Actual: Link has relative path /index.php/publicknowledge/en/authorDashboard/submission/13 but It jumps to root and there is a error in console (see screenshot)
Expected: It should go to the relative path and not have an error in console.

What application are you using?
OJS, OMP or OPS version X.X.X

Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.
Image

@Tribunal33 Tribunal33 added Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us? labels Dec 14, 2024
@Tribunal33 Tribunal33 added this to the 3.5 Internal milestone Dec 14, 2024
@asmecher
Copy link
Member

@Tribunal33, this is happening because the datasets you're using generate URLs relative to the root, and your local hosting setup has OJS installed in a subdirectory somewhere (or similar). I think the syntax error is possibly a red herring from landing on a page outside of OJS that's causing a console error. Make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Development

No branches or pull requests

2 participants