Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload file - Cancelling upload file results in error and does not prevent the uploaded file #10705

Open
Tribunal33 opened this issue Dec 14, 2024 · 2 comments
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Milestone

Comments

@Tribunal33
Copy link

Tribunal33 commented Dec 14, 2024

Describe the bug
Seems to be an issue with upload module on 3.4 and 3.5 versions. There are two issues. First, is after selecting a file to upload the cancel button no longer prevents the uploaded of the file to show up on the submission list. Second, the cancel button doesn't immediately close the workflow and when the user selects continue it shows that there is a file not found error in the console.
Potentially connected to #10660 but not the revision scenario.

Preconditions :
Default dataset

To Reproduce
Steps to reproduce the behavior:

  1. Login using any user that can upload a file
  2. Select any submission or go to any upload file workflow (used ID 13 Kumiega for example)
  3. Select Upload to open the upload file window
  4. Select "This is not a revision of an existing file" <-- don't know how important these steps are
  5. Select any Article Component from the dropdown list
  6. Select Upload File
  7. Choose a file to upload
  8. Select Cancel <--- after one cancel being selected the window should close
  • Select Cancel again for first issue in which the cancelled upload is added to the file list
  • Select Continue for the second issue with the dev console open to see the error message (in screenshot below)

Actual : The first issue results in the file being added to the list even though the user tries to cancel the upload. The second issue shows an error in the console.
Expected: The file should not be uploaded if the user selects Cancel at any point in the workflow and no error in console when selecting continue.

What application are you using?
OJS, OMP or OPS version 3.4.0 and 3.5.0

Additional information
Please add any screenshots, logs or other information we can use to investigate this bug report.
Image

@Tribunal33 Tribunal33 added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Dec 14, 2024
@Tribunal33 Tribunal33 added this to the 3.5 Internal milestone Dec 14, 2024
@asmecher
Copy link
Member

@Tribunal33, is this the same as #10660?

@Tribunal33
Copy link
Author

I think that has a similar root problem but not exactly the same. The problem is that it adds a file that is cancelled rather than removing an existing file.

@jardakotesovec jardakotesovec added the Try Me This issue might be good for a new contributor. Can you help us? label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. Try Me This issue might be good for a new contributor. Can you help us?
Projects
None yet
Development

No branches or pull requests

3 participants