Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit open Task questions #3

Open
1 of 6 tasks
duesee opened this issue May 30, 2024 · 0 comments
Open
1 of 6 tasks

Revisit open Task questions #3

duesee opened this issue May 30, 2024 · 0 comments

Comments

@duesee
Copy link
Collaborator

duesee commented May 30, 2024

  • Use Type, impl, and impl Trait ordering
    • I usually use Type, Implementations, Trait Implementations (similar to the Rust docs) in imap-types and imap-codec. In imap-flow it's not always consistent. I think this could be our default. But, in the end, let's use what makes most sense for a specific situation :-)
  • Use builder for Tasks
  • Fetch vs Fetch{Single,Many}
  • clone()s required due to Task trait
  • Consistency between seq and uid
  • Discuss ...Data data structures
  • ...

Some guidance about implementing Tasks (potentially useful for docs) ...

  • Don't drop usable information (see functions-expose-intermediate-results-to-avoid-duplicate-work-c-intermediate)
    • If another representation makes more sense, provide an explicit conversion
  • Remember most recent Data
    • Replace duplicate Data emitting a warn!ing (using structured values)
    • Replace Data when there is a code with the same meaning in Status emitting a warn!ing (using structured values)
  • ...
@soywod soywod changed the title refactor: Revisit open Task questions Revisit open Task questions Sep 10, 2024
@soywod soywod added this to Pimalaya Sep 10, 2024
@soywod soywod moved this to Todo in Pimalaya Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant