Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add button to pull from igdb api for game metadata #26

Closed
jmshgs opened this issue Jun 17, 2023 · 9 comments
Closed

add button to pull from igdb api for game metadata #26

jmshgs opened this issue Jun 17, 2023 · 9 comments
Assignees
@jmshgs
Labels
enhancement New feature or request

Comments

@jmshgs
Copy link
Member

jmshgs commented Jun 17, 2023

No description provided.

@jmshgs jmshgs added the enhancement New feature or request label Jun 17, 2023
@jmshgs jmshgs self-assigned this Jun 17, 2023
@jmshgs jmshgs changed the title add button to run a web scraping program that pulls game data add button to pull from igdb api for game metadata Jun 24, 2023
@jmshgs jmshgs removed their assignment Aug 24, 2023
@jmshgs
Copy link
Member Author

jmshgs commented Sep 7, 2023 •
edited
Loading

currently all metadata is being pulled in except for:

  • header image
  • icon

the icon will need to be fetched from macosicons.com but there isn't an API yet. I dmed @elrumo on Twitter about it.

the game cover should also be pulled in for #59

@elrumo
Copy link

elrumo commented Sep 7, 2023

I've thought about having an API for it, but I haven't figured out a way that keeps users from abusing it. I might have to to add rate limits after which you'd need to pay so that I could at least cover the server costs, which is what the ads on the website do.

I'm on holidays at the moment, but I might be willing to do it for free for you guys to test it. Do you have an estimate of how many calls you'd need to make monthly?

@Shock9616
Copy link
Member

How many calls would be problematic? For testing I can't imagine it would be very much. There's only 3 current devs who would be testing before it's added to a release, and once it is, this is something that each user will do once and then never again. Right now we don't have a very large userbase (our last release only has 12 downloads) but I don't really have any way of telling how many we will have once we release version 1.0.

@jmshgs
Copy link
Member Author

jmshgs commented Sep 8, 2023 •
edited
Loading

Yeah we have a very small user-base and won't even be rolling out this feature yet so not many calls will happen. I'd estimate a few hundred at the max monthly, more realistically 100-200 monthly. Enjoy your holiday!

@jmshgs
Copy link
Member Author

jmshgs commented Oct 1, 2023

need to fix dupe devs and pubs

@jmshgs jmshgs self-assigned this Oct 5, 2023
@jmshgs jmshgs mentioned this issue Oct 5, 2023
Closed
@jmshgs
Copy link
Member Author

jmshgs commented Oct 26, 2023

done in igdb

@jmshgs
Copy link
Member Author

jmshgs commented Nov 11, 2023

merged in #74

@jmshgs jmshgs closed this as completed Nov 11, 2023
@elrumo
Copy link

elrumo commented Sep 30, 2024

Hey there! I finally came around building an API for macOSicons. Right now it only let's you search for icons, but I might implement the option to limit to certain categories, like games. You can check it out here: https://docs.macosicons.com/

@jmshgs
Copy link
Member Author

jmshgs commented Oct 3, 2024

thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmshgs jmshgs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Shock9616 @elrumo @jmshgs