Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards incompatible change in DEFINE-PROTOCOL-CLASS #9

Open
phoe opened this issue Jul 7, 2020 · 1 comment
Open

Backwards incompatible change in DEFINE-PROTOCOL-CLASS #9

phoe opened this issue Jul 7, 2020 · 1 comment

Comments

@phoe
Copy link
Owner

phoe commented Jul 7, 2020

Currently, PROTEST/BASE:DEFINE-PROTOCOL-CLASS defines a method on INITIALIZE-INSTANCE. This is buggy, since this means that it is still possible to create instances of the protocol class by e.g. using CHANGE-CLASS. This means that, in the future, DEFINE-PROTOCOL-CLASS will also define methods on UPDATE-INSTANCE-FOR-REDEFINED-CLASS to prevent such.

This issue is a warning to all clients of this method to ensure that they do not have. It's unlikely to have them, since changing classes to/from protocol classes is a weird thing to do, but I nonetheless post this here.

@phoe
Copy link
Owner Author

phoe commented Feb 1, 2021

22:30 < Bike> but you can still change-class to the protocol class! mwa ha HA!
22:30 < phoe> :O
22:30 < phoe> oh my
22:30 < jmercouris> well, of course you can even override the macro if you so desire
22:30 < jmercouris> I could change package, and redefine the macro
22:30 < jmercouris> that is however not the spirit of the package...
22:33 < Bike> i guess you could put a before/after method on update-instance-for-different-class to be 
              really particular about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant