Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No failure if no expected folder #48

Open
pkrog opened this issue Feb 28, 2018 · 1 comment
Open

No failure if no expected folder #48

pkrog opened this issue Feb 28, 2018 · 1 comment
Labels

Comments

@pkrog
Copy link
Member

pkrog commented Feb 28, 2018

If an expected field is provided inside a workflow YAML file with a list of output files, and no folder expected is provided, wft4galaxy does not fail.

@pkrog pkrog added the bug label Feb 28, 2018
@davidchristiany
Copy link

I have the same bug, I defined my output files to compare with :
expected:
dereplicated_file:
file: "expected/FROGS_Pre-process__count.tsv"

And the file is not checked.
In fact, I can put whatever I want in the expected file and the test will not fail.
So output files are clearly not compared, even if I get this:
2019-06-12 17:11:09,728 [wft4galaxy.runner] [ INFO] Checking test output: ...
2019-06-12 17:11:09,729 [wft4galaxy.runner] [ INFO] Checking test output: DONE

Maybe I miss something but if output files can not be compared with expected files, I don't see the point of doing such workflow test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants