Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trouble picking up vectors on the graph #263

Closed
pixelzoom opened this issue Oct 30, 2019 · 8 comments
Closed

trouble picking up vectors on the graph #263

pixelzoom opened this issue Oct 30, 2019 · 8 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 30, 2019

For phetsims/qa#445 and phetsims/qa#446.

In #250 (comment), @KatieWoe reported:

I noticed in phetsims/qa#445 that on iPad I honestly had a bit more trouble picking up active vectors on the graph. Not quite enough for its own issue, but @arouinfar might want to take a look.

@pixelzoom
Copy link
Contributor Author

Me in #250 (comment):

Let's be sure we're all using "active vector" the same way. The active vector is the selected vector, and there can be at most one active vector. All vectors on the graph have the same pointer areas, regardless of whether they are active (selected) or inactive (unselected). So... @KatieWoe do you really mean "active vector" or do you mean any vector that's on the graph?

@KatieWoe in #250 (comment)

Either, the pointer area size doesn't differ, just any that is on the graph. I did notice a bit more with active vectors.

@pixelzoom
Copy link
Contributor Author

@KatieWoe said:

... I did notice a bit more with active vectors.

I'm not sure why that would be the case. Pointer areas for active and inactive vectors are identical. For example, 'a' is active, 'b' is inactive:

screenshot_1653

@KatieWoe
Copy link
Contributor

It was mostly because the Vector Value box would stop showing the values

@pixelzoom
Copy link
Contributor Author

I'm confused.... By "Vector Value box" do you mean "Vector Values accordion box"? And why would whether that shows values affect your ability to grab a vector?

@pixelzoom
Copy link
Contributor Author

Here are the current values for vector pointer areas in VectorAdditionConstants.js. The first pair of values is applied to the entire arrow and affects translation. The second pair of values is applied to the arrow head, and affects rotation and scaling.

    // dilation of vector (arrow) pointer areas
    VECTOR_TOUCH_AREA_DILATION: 3,
    VECTOR_MOUSE_AREA_DILATION: 3,

    // dilation of vector head pointer areas, for vectors that can be scales/rotated
    VECTOR_HEAD_TOUCH_AREA_DILATION: 8,
    VECTOR_HEAD_MOUSE_AREA_DILATION: 6,

@KatieWoe
Copy link
Contributor

Yes. I just meant that when I missed the active vector, the the Vector Values accordion box would show it immediately since it would stop showing the values. Sometimes I could miss it if I picked up the vector by sliding my finger, but the active vector was more obvious.

@pixelzoom
Copy link
Contributor Author

Assigning to @arouinfar to advise on how to proceed.

@arouinfar arouinfar mentioned this issue Oct 31, 2019
4 tasks
@arouinfar
Copy link
Contributor

I've been testing quite a bit on my phone, and I do not have trouble translating the vectors or picking up the active vector. I think the trick is to grab the vector by its label, since that is also grabbable. I'll make a note of this in the Teacher Tips.

I am hesitant to dilate the touch areas any further because there could be spillover to neighboring vectors. Since the problem was reported for active vectors (which always have labels), I think this is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants