Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBoxButton shrinks as locale is changed. #889

Open
pixelzoom opened this issue Aug 1, 2024 · 4 comments
Open

ComboBoxButton shrinks as locale is changed. #889

pixelzoom opened this issue Aug 1, 2024 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 1, 2024

This is a (new?) problem with ComboBox, and I'm seeing it in all sims. As locale is changed, the ComboBoxButton gets progressively smaller. I'm seeing this in main with balancing-chemical-equations, beers-law-lab, geometric-optics, ph-scale, ...

To demonstrate in balancing-chemical-equations:

  1. From phetmarks, run http://localhost:8080/balancing-chemical-equations/balancing-chemical-equations_en.html?brand=phet&ea&debugger&locales=*
  2. Got to the Intro screen.
  3. Open Preferences > Localization. Note the size of the Tools combobox in the upper-right corner of the screen:
screenshot_3442

5. Select each Locale in order, starting from "Afaan Oromoo". Note that the ComboBoxButton gets progressively smaller. By the time you select "English" from the Localization tab, the combobox will look like this:
screenshot_3440

6. Keep selecting locales and the ComboBoxButton will continue to get smaller: screenshot_3441
@jonathanolson
Copy link
Contributor

Fixed in the commit above. @pixelzoom can you verify?

@marlitas
Copy link
Contributor

marlitas commented Aug 1, 2024

I confirmed this is now working on the local version of MSaB.

@samreid
Copy link
Member

samreid commented Aug 5, 2024

@marlitas confirmed it does not need a maintenance release. @marlitas reviewed the proposed solution and it seems good.

@pixelzoom
Copy link
Contributor Author

Tested in BCE and this appears to be fixed in main.

Comments above indicate that an MR is needed, so assigning to @jonathanolson.

@pixelzoom pixelzoom assigned jonathanolson and unassigned pixelzoom Aug 7, 2024
marlitas pushed a commit that referenced this issue Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants