Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhET-iO instrumentation of 'spinner' UI components. #881

Open
pixelzoom opened this issue Apr 29, 2024 · 1 comment
Open

PhET-iO instrumentation of 'spinner' UI components. #881

pixelzoom opened this issue Apr 29, 2024 · 1 comment
Labels
design:phet-io dev:phet-io

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 29, 2024 •
edited
Loading

Related to UI phetsims/scenery-phet#460 ...

PhET has a few variations of the standard 'spinner' UI component: NumberSpinner, NumberPicker, FineCoarseSpinner. Their PhET-iO instrumentation is not at all consistent, and in most cases over-instrumented. It would be worth reviewing and coming up with a standard instrumentation for spinners.
@pixelzoom pixelzoom changed the title NumberSpinner is over instrumented. PhET-iO instrumentation of 'spinner' UI components. May 7, 2024
@pixelzoom
Copy link
Contributor Author

As noted in phetsims/scenery-phet#460 (comment) for FineCoarseSpinner, but applicable to all spinners:

@arouinfar and I discussed this in the context of phetsims/gas-properties#30.

A better PhET-iO API for spinners would be:

  • No instrumentation of the NumberDisplay
  • No instrumentation of the individual buttons
  • A Property that allows you to show/hide all buttons, to turn the spinner into a display.

@zepumph zepumph mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design:phet-io dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @brent-phet