Circularity caused by ResetAllButton.isResettingAllProperty

[jonathanolson]

Finally identified the Vite failure I've been tracking for a while. Results in it trying to load ResetAllButton before it has loaded ResetButton, resulting in a failure for npx vite serve (the default/fast/best way of running things that scenerystack wants to support).

After building scenerystack, npx madge --ts-config ./tsconfig.json --warning --circular ./src detects circularities. The two offending circular dependency chains are:

• tambo/js/sharedSoundPlayers.ts
• tambo/js/sound-generators/SoundClipPlayer.ts
• tambo/js/sound-generators/SoundClip.ts
• tambo/js/sound-generators/SoundGenerator.ts
• scenery-phet/js/buttons/ResetAllButton.ts
  • (A) directly to sharedSoundPlayers
  • (B) ResetButton => RoundPushButton => sharedSoundPlayers

The most logical path forward (that I see at the moment) is to extract ResetAllButton.isResettingAllProperty into its own file, so that it doesn't force loading of the button chain (and breaks the circular dependency).

[jonathanolson]

@jbphet can you briefly check this to see if it's acceptable and looks correct?