Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GroupSortInteraction] Cue Logic to handle individually disabled items #865

Open
marlitas opened this issue Aug 19, 2024 · 1 comment
Open

Comments

@marlitas
Copy link
Contributor

This issue comes from phetsims/mean-share-and-balance#337 (comment)

We understand that GroupSortInteraction does not currently support proper cue behavior for individually disabled balls. This is an enhancement that should eventually be added to GroupSort.

Assigning to @zepumph to begin with in case he has anything to add.

@zepumph
Copy link
Member

zepumph commented Aug 19, 2024

Yeah. This is a challenge since the cue visibility logic exists in the model, but the general notion of item enabled is Node.enabled. This meant that over in the above issue, we decided to add individual enabled over in the view in 3690a61.

Some challenges with supporting this in the model:

  1. ItemModel as a type would want to support some sort of enabledProperty.
  2. Ideally we combine enabled strategies, and don't just keep the view option from the above commit (isGroupItemEnabled).
  3. A good default for this logic is Node.enabled, but I'm unsure how that would be able to live in the model type.
  4. This issue recognizes that the model/view pattern is a bit strange here, since all model Properties are really about the controller/view interaction, and thus create problems with wanting Node Properties in the GroupSortInteractionModel (which still seems "view-like" per say).

See also phetsims/mean-share-and-balance#337 (comment) for the same-kind of thoughts.

I'm not planning to work on this, but it seems valuable to track for next time we work on group sort.

@zepumph zepumph changed the title Enhance GroupSortInteraction Cue Logic to handle individually disabled balls [GroupSortInteraction] Cue Logic to handle individually disabled items Aug 19, 2024
@zepumph zepumph removed their assignment Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants