Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beaker contains slight concentration after 'Reset All' #73

Closed
pixelzoom opened this issue Jul 22, 2014 · 4 comments
Closed

Beaker contains slight concentration after 'Reset All' #73

pixelzoom opened this issue Jul 22, 2014 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

Originally reported by @bryo5363 in phetsims/joist#138.

While using the Concentration simulation or the Concentration portion of Beer's Law, it is possible to restart the simulation with an initial concentration. I am testing on iOS 8. This is a multitouch issue

Steps to reproduce
-Open simulation
-Use one finger to evaporate the water
-Press 'Reset All' button with other finger while water is evaporating
-Add solvent to water prior to evaporation
-Repeat evaporating solution with one finger and 'Reset All' with another finger
-The solution will have an initial concentration.

@pixelzoom
Copy link
Contributor Author

I believe that in the above description, "restart" should be "reset", as in pressing the "Reset All" button. I've changed the issue title and description to reflect this.

@pixelzoom
Copy link
Contributor Author

This is a general issue of what to do when the "Reset All" button is pressed while other interactions are in progress. I seem to recall a related issue in one of the common-code repos, but can't find it. In any case, we need to have a general discussion about this, because it affects all sims.

@pixelzoom pixelzoom changed the title Tank contains slight concentration after restarting simulation Tank contains slight concentration after resetting simulation Sep 29, 2014
@pixelzoom pixelzoom changed the title Tank contains slight concentration after resetting simulation Beaker contains slight concentration after 'Reset All' Sep 29, 2014
@pixelzoom
Copy link
Contributor Author

I think the issue here is that sun.HSlider needs a way to cancel an interaction that is in progress. When the "Reset All" button is pressed, the dragging of the Evaporation slider (and all interactions, actually) should be ended. It currently continues. I believe there's a scenery issue that considers a more system-wide solution, which is to provide a way to end all interactions that are currently in progress.

@pixelzoom pixelzoom removed their assignment Jan 16, 2015
@pixelzoom pixelzoom assigned pixelzoom and unassigned pixelzoom Aug 30, 2015
@pixelzoom
Copy link
Contributor Author

This is a general issue, tracked in phetsims/scenery#218. It's not appropriate to handle this specific case (and undoubtedly others) in this sim, it should be addressed generally.

I'm closing this issue as 'won't fix'. If @ariel-phet or anyone else disagrees, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant