-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CanvasLinePlot's lack of support for color Property #42
Comments
Brainstorming a proposal:
|
I've built something similar to that proposal into HarmonicPlot and InfiniteHarmonicPlot. Basically the same pattern as used in ChartTransform. |
I started to implement the proposal to add a Closing. |
For #47... This issue was raised by @jonathanolson in the code-review for Fourier (phetsims/fourier-making-waves#165. And I (unsuccessfully) tried to handle it in sim-specific code in phetsims/fourier-making-waves#174. So it seems appropriate to reopen this issue - support for stroke Property is clearly something that CanvasLinePlot should have. |
Unassigning because I doubt that we'll see progress on this for awhile. Let me know when you'd like to discuss. |
It seems good to touch base on this. There was a proposal in #42 (comment), and it seems that or something similar was investigated in #42 (comment). So perhaps we should create a dev meeting subgroup: @pixelzoom @jonathanolson and myself? I'll try that and see if that helps us come up with a plan. |
#42 (comment) seems workable, as long as it doesn't kill performance when a lot of painters are added/removed each frame (there may be cases like that?) |
+1 for @samreid's proposal in #42 (comment), with one caveat. The |
Unassigning since I am not scheduled any time for this part of bamboo in the current quarter. This issue will not be lost since I am the responsible dev for the repo. |
CanvasLinePlot does not support
{Property} stroke
because any change to CanvasLinePlot requires callingupdate
for the parent ChartCanvasNode.In practice, this is causing 2 problems:
(1) I'm constantly forgetting that
stroke
can't be a Property, and writing code like this that fails an assertion in CanvasLinePlotsetStroke
:(2) To use a color Property (e.g. a
ProfileColorProperty
) requires boilerplate like this, which occurs 3x in Fourier:I don't know how to resolve this, and maybe we don't. But I thought I'd create this issue, and do a little brainstorming, since this API is proving to be a little wonky in practice.
@samreid thoughts?
The text was updated successfully, but these errors were encountered: