Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review BitmapFillStyle>>fromUser #5922

Open
guillep opened this issue Mar 17, 2020 · 1 comment · May be fixed by #16834
Open

Review BitmapFillStyle>>fromUser #5922

guillep opened this issue Mar 17, 2020 · 1 comment · May be fixed by #16834
Labels
Easy Project: Graphics Athens, Bloc, Morphic, Fonts, etc.

Comments

@guillep
Copy link
Member

guillep commented Mar 17, 2020

It asks the user for a form and then creates a fill style from it.
It seems unused from the outside, and of limited value.

I propose to deprecate/remove it.

@guillep guillep added Easy Project: Graphics Athens, Bloc, Morphic, Fonts, etc. labels Mar 17, 2020
@GeraldineGalindo
Copy link

Good evening! I was reviewing the class and the method, and I wanted to make a question about the action that should be taken.

About the class, I searched it on the finder tool, using source filter, it found only one appearance, the one shown in the picture below, but calling fromForm: .

image

I also reviewed the source code of fromUser and fromForm: and both are very similar, excepting, of course, the argument sent in the second one, considering this, with no appearances of fromUser method it may be convenient to remove it but if some projects use the method, it could be deprecated and the suggestion can be to directly use fromForm: . But, which one should be the most appropriate to do? Are there any criteria or information that I can look for to clarify this?

Thanks a lot in advance for the clarification!!

fouziray added a commit to fouziray/pharo that referenced this issue Jun 28, 2024
@fouziray fouziray linked a pull request Jun 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Project: Graphics Athens, Bloc, Morphic, Fonts, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants