Support for interim numbers. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Signed-off-by: Johannes Tegnér <[email protected]>
Johannestegner
force-pushed
the
feature/interim
branch
from
23eb068 to
7a69af3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR includes a few different changes to make the package adhere to the v3.1 specification (https://github.com/personnummer/meta#package-specification-v31).
Interim numbers have been introduced to the package. Tests included.
A strlen check have been made on the initial input (in constructor), throwing an error if the string is under 10 chars and over 13 (if it is, it's not a correctly formatted number and can be discarded directly).
The
public function getDate() : Date;implementation have not yet been added, hence, the package will not be fully ready for a 3.1 compliant release, while, if released, it should most likely be a major or minor release (seeing this is a lot more than a patch change).Related issue
#60
Motivation
We want the packages to be using the latest spec! :)
Checklist