Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market buy estimations are inverted #221

Open
hdevalence opened this issue Dec 16, 2024 · 2 comments
Open

Market buy estimations are inverted #221

hdevalence opened this issue Dec 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hdevalence
Copy link
Member

Screenshot 2024-12-16 at 2 51 08 PM

Since UM is above $1, "pay with" should be 1.0955 USDC
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Dec 16, 2024
@grod220 grod220 moved this to 📝 Todo in Labs web Dec 17, 2024
@grod220 grod220 added this to Labs web Dec 17, 2024
@grod220 grod220 added the bug Something isn't working label Dec 17, 2024
@VanishMax
Copy link
Contributor

@hdevalence this seems to be correct – it's not that the price is inverted but we simulate trade and some amounts cause large price impact that makes average price slightly different from the market price.

Maybe we should add more info about the price impact in the tooltip?

Image

@VanishMax VanishMax moved this from 📝 Todo to 🛑 Blocked in Labs web Dec 23, 2024
@hdevalence
Copy link
Member Author

No, I don't think so. If 1 UM = 1.0955 USDC then if I put "1 UM" into the Buy field, I should expect to spend 1.0955 USD. The data shown in the screenshot is not internally consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Penumbra web
Status: 🗄️ Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hdevalence @grod220 @VanishMax