Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline network errors #219

Closed
TalDerei opened this issue Dec 14, 2024 · 2 comments
Closed

offline network errors #219

TalDerei opened this issue Dec 14, 2024 · 2 comments
Labels

Comments

@TalDerei
Copy link
Contributor

intentionally disconnected wifi to see more error states. We should implement some kind of graceful fallback UI that hides or disables features that rely on network connectivity, or maybe display an offline modal, or backfilling these components with loading skeletons instead of displaying loading errors?

Screenshot 2024-12-13 at 4 54 48 PM
@grod220
Copy link
Contributor

grod220 commented Dec 14, 2024

Don't think we need a non-wifi-connected UI state for our components and we can just do #211 to match what the error states should be rendered like.

@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Dec 14, 2024
@TalDerei
Copy link
Contributor Author

missed that error states issue, that's more in the spirit of a resolution I had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants