Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search returns apps where is_visible is true #9

Open
Willow-Systems opened this issue Mar 19, 2021 · 1 comment
Open

Search returns apps where is_visible is true #9

Willow-Systems opened this issue Mar 19, 2021 · 1 comment
Assignees

Comments

@Willow-Systems
Copy link
Member

Willow-Systems commented Mar 19, 2021

Apps have a visibility flag Link to code.

When this is 'false' it causes the app to be hidden in collections.
The app can still be viewed with the direct link
These are both expected behavior.

However, searching for the app will still show it in the search results. I have no idea how the agolia/search stuff works, so not sure what needs to be done to resolve this bug.

To replicate:

  • Find an app in the appstore database, apps table with 'is_visible' = false.
  • Search for the app
  • Observe it being returned
@Willow-Systems
Copy link
Member Author

Willow-Systems commented Mar 19, 2021

(@jwise I assigned to you because I'm guessing (read: hoping) you understand the search code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants