Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System requires ID="documentViewer", causing errors. #410

Open
GoogleCodeExporter opened this issue May 10, 2015 · 1 comment
Open

System requires ID="documentViewer", causing errors. #410

GoogleCodeExporter opened this issue May 10, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.  Create a page with two document viewers.
2.  Give them IDs that are not documentViewer
3.  Try switching to 2 page view.  Other ways, but this one was fastest.

What is the expected output? What do you see instead?

Expected: 2 page view.  Result: Uncaught TypeError: Cannot read property 
'onAddedTextOverlay' of null

What version of the product are you using? On what operating system?

2.2.9 with Annotations Plugin 2.2.9-1.0.91.  Windows 7.

Please provide any additional information below.

The cause of this issue is the requirement for FlexPaper elements to use the ID 
documentViewer.  There are 4 instances in FlexPaperViewer.js which explicitly 
query: jQuery('#documentViewer') or $FlexPaper('documentViewer') instead of 
using the object's initialized ID.

While I can fix flexpaper.js, I can't touch FlexPaperViewer.js.

Original issue reported on code.google.com by [email protected] on 22 Oct 2014 at 4:45

@GoogleCodeExporter
Copy link
Author

This may not be the cause of the JS error with 2 page view.  I modified my 
implementation to reconstruct the document view using the ID documentViewer, 
and still received the error.

However, changing to documentViewer allows Highlight and Strikeout to work for 
all my documents now, where it did not if you don't use the ID documentViewer.

Original comment by [email protected] on 22 Oct 2014 at 5:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant