Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab bindings improvements/updates #160

Open
patrikhuber opened this issue Nov 2, 2017 · 6 comments
Open

Matlab bindings improvements/updates #160

patrikhuber opened this issue Nov 2, 2017 · 6 comments

Comments

@patrikhuber
Copy link
Owner

patrikhuber commented Nov 2, 2017

The Matlab bindings are not updated to work with v0.13.0. They probably need changes to work with Eigen matrices as well as core::Image.

Contributions for this are welcome. It shouldn't be too hard.
I currently don't have time to maintain them, as I'm only using the Python bindings (which are awesome! :-) ).

In the meantime, the Matlab bindings in v0.12.2 should work.

@Ostnie
Copy link

Ostnie commented Jan 2, 2018

[removed by patrikhuber - unrelated post]

@patrikhuber
Copy link
Owner Author

@Ostnie I'm going to remove your posts here as they're not at all related to eos's Matlab bindings. If there is some issue with the eos library, please open a separate issue. Thanks!

Repository owner deleted a comment from Ostnie Jan 4, 2018
@patrikhuber
Copy link
Owner Author

Removed wontfix for @FengZhenhua - we'll try to get to updating the Matlab bindings in the near future.

@patrikhuber
Copy link
Owner Author

Adding this here for reference: Very valuable information. kyamagu/mexplus#14

@patrikhuber
Copy link
Owner Author

patrikhuber commented May 3, 2018

A first set of updates (probably the most important one!) is done: The eos-matlab-fitting bindings now compile again with the latest eos version.

Open todo's:

  • Add MorphableModel class bindings so that the model doesn't have to be loaded with each fit(...) call
  • Improve the documentation
  • Update the README.md
  • Add back the eos-matlab-render bindings

@patrikhuber patrikhuber changed the title Matlab bindings not updated to work with v0.13.0 Matlab bindings improvements/updates May 3, 2018
@patrikhuber
Copy link
Owner Author

Just for later reference: This post RobotLocomotion/drake#1267 (comment) has some approach that proposes to use variadic templates.
matlab-mex-variadic-templates.txt

But from R2018a, Matlab has a C++ mex API now! I am currently checking it out. It's hopefully the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants