Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formats such as block-quotes, code-blocks, code are unescapable. #39

Open
wooolfgang opened this issue Jun 3, 2020 · 4 comments
Open

Comments

@wooolfgang
Copy link

wooolfgang commented Jun 3, 2020

Currently, there is no way to escape from formats such as blockquotes and code-blocks. The favorable behavior UX-wise is to remove the format when the current line is empty.

Here's a demo of the issue:
https://www.loom.com/share/392c057b0a0147e0bbf0bed13adbb67e

If anyone's interested, I've forked this current branch and made some fixes that solve this issue here forked branch.

Here's the demo of the updated UX behavior:
https://www.loom.com/share/55f49afcdd9c473da9bb09653fb38abf

@tsi
Copy link

tsi commented Jul 16, 2020

Yes, that's annoying, we need this too.
any chance it's merged into main repo anytime soon?

@wooolfgang
Copy link
Author

The author seems inactive in resolving the PR's for this repo. I'd recommend going our route which is forking this instead.

@duhaime
Copy link

duhaime commented Jan 16, 2022

@wooolfgang your fork looks great. If I wanted to add a change such that the down arrow key moved the cursor out of e.g. the code block in which the user had finished typing (as is the case in Slack), do you know how I could add that behavior?

Was there a reading source that was helpful as you made the changes in your repo? Any advice would be appreciated!

@artknight
Copy link

artknight commented Sep 3, 2022

@wooolfgang I tried including the code as a script tag but it throws an error with the import

Screen Shot 2022-09-03 at 8 24 30 AM

It seems that it is complaining about this line const Block = Quill.import('blots/block') that you added.

Any chance you could fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants