Repeated object creation

[JiaRG]

Achtung2/Source/Tools.cs

Lines 33 to 45 in 209d8fc

	public static WorkTypeDef RescuingWorkTypeDef => new()
	{
	defName = "Rescuing",
	labelShort = "WorkType_Rescue_Label".Translate(),
	pawnLabel = "WorkType_Rescue_PawnLabel".Translate(),
	gerundLabel = "WorkType_Rescue_GerundLabel".Translate(),
	description = "WorkType_Rescue_Description".Translate(),
	verb = "Rescue",
	naturalPriority = 1310,
	alwaysStartActive = true,
	workTags = WorkTags.Caring | WorkTags.Commoner | WorkTags.AllWork
	};

Achtung2/Source/Settings.cs

Lines 132 to 135 in 209d8fc

	if (rescuing == null && Achtung.Settings.rescueEnabled)
	Tools.savedWorkTypeDef = DynamicWorkTypes.AddWorkTypeDef(Tools.RescuingWorkTypeDef, WorkTypeDefOf.Doctor, doctorRescueWorkGiver);
	else if (rescuing != null && Achtung.Settings.rescueEnabled == false)
	DynamicWorkTypes.RemoveWorkTypeDef(Tools.RescuingWorkTypeDef, Tools.savedWorkTypeDef, doctorRescueWorkGiver);

Achtung2/Source/Main.cs

Lines 210 to 213 in 209d8fc

	var rescuing = DefDatabase<WorkTypeDef>.GetNamedSilentFail(Tools.RescuingWorkTypeDef.defName);
	var doctorRescueWorkGiver = DefDatabase<WorkGiverDef>.GetNamed("DoctorRescue");
	if (rescuing == null && Achtung.Settings.rescueEnabled)
	Tools.savedWorkTypeDef = DynamicWorkTypes.AddWorkTypeDef(Tools.RescuingWorkTypeDef, WorkTypeDefOf.Doctor, doctorRescueWorkGiver);

Tools.RescuingWorkTypeDef Calling it multiple times will generated different object.

[pardeike]

Yes, that is correct

[JiaRG]

Shouldn't RescuingWorkTypeDef be a single case? In this case, adding and removal are the same object

[pardeike]

Sorry but I don’t understand what you are saying.

[JiaRG]

like this

private static readonly Lazy<WorkTypeDef> Lazy = new(() => new()
{
	defName = "Rescuing",
	labelShort = "WorkType_Rescue_Label".Translate(),
	pawnLabel = "WorkType_Rescue_PawnLabel".Translate(),
	gerundLabel = "WorkType_Rescue_GerundLabel".Translate(),
	description = "WorkType_Rescue_Description".Translate(),
	verb = "Rescue",
	naturalPriority = 1310,
	alwaysStartActive = true,
	workTags = WorkTags.Caring | WorkTags.Commoner | WorkTags.AllWork
});

public static WorkTypeDef RescuingWorkTypeDef => Lazy.Value;	

Each call of Tools.RescuingworkTypef will only generate an object instance

[pardeike]

Why is it important to only have one instance? It’s a tiny object and will get garbage collected as soon as no references to it exist anymore.

[JiaRG]

Achtung2/Source/DynamicWorkTypes.cs

Lines 128 to 132 in 209d8fc

	DefDatabase<WorkTypeDef>.Remove(def);
	var columnDef = DefDatabase<PawnColumnDef>.AllDefsListForReading.FirstOrDefault(d => d.workType == oldWorkGiver);
	if (columnDef != null)
	DefDatabase<PawnColumnDef>.Remove(columnDef);

If there is only one instance, the remove operation don't need 130-132 code , right?

[pardeike]

Well, it’s not only about the worktab visuals. The def database has significant influence on mods and the base game