[CLI] Support compiling for multiple targets together #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for multiple targets in .pproj file using <Target> field Adds <pobserve-package> field in .pproj
ankushdesai
requested changes
Oct 2, 2023
| @@ -14,18 +14,18 @@ namespace UnitTests.Runners | |||
| /// </summary> | |||
| public class CompileOnlyRunner : ICompilerTestRunner | |||
| { | |||
| private readonly CompilerOutput compilerOutput; | |||
| private readonly IDictionary<string, CompilerOutput> compilerOutputs; | |||
There was a problem hiding this comment.
Good catch! Don't need a dictionary in this final version. Update to list via dd21650
| @@ -183,43 +208,48 @@ private string GetOutputDirectoryName(FileInfo fullPathName) | |||
| return Directory.GetCurrentDirectory(); | |||
| } | |||
|
|
|||
| private void GetTargetLanguage(FileInfo fullPathName, ref CompilerOutput outputLanguage, ref bool generateSourceMaps) | |||
| private IDictionary<string, CompilerOutput> GetTargetLanguages(FileInfo fullPathName) | |||
There was a problem hiding this comment.
Why is the return value a dictionary and not a list?
There was a problem hiding this comment.
Update to list via dd21650
ankushdesai
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates include:
<Target>field in *.pproj file. E.g.,<Target>CSharp, PObserve, Stately, Symbolic</Target><pobserve-package>