Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make poscounts accessible from .deseq2() #340

Closed
BorisMuzellec opened this issue Nov 21, 2024 · 1 comment
Closed

Make poscounts accessible from .deseq2() #340

BorisMuzellec opened this issue Nov 21, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BorisMuzellec
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

DeseqDataSet.fit_size_factors() has a fit_type=poscounts option to take the average on positives reads only, but it is neither accessible when initializing a DeseqDataSet or when running .deseq2().

This means it can only be used by calling dds.fit_size_factors(fit_type=poscounts) manually.

Describe the solution you'd like

Add a size_factor_fit_type argument to either DeseqDataSet (in which case it would also become an attribute) or .deseq2()

Additional context
I'm wondering whether poscounts would be a better fall-back option than iterative, given how buggy the iterative mode is (cf #198).

This would introduce another difference compared with DESeq2 though.

@BorisMuzellec BorisMuzellec added enhancement New feature or request good first issue Good for newcomers labels Nov 21, 2024
@BorisMuzellec
Copy link
Collaborator Author

Solved by #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant