Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Balances persists when transactions are deleted #130

Open
ptsimon opened this issue Oct 24, 2024 · 4 comments
Open

Bug: Balances persists when transactions are deleted #130

ptsimon opened this issue Oct 24, 2024 · 4 comments

Comments

@ptsimon
Copy link

ptsimon commented Oct 24, 2024

I have an issue here with my group. I have added some transactions in a group before that led me to a balance, then deleted the all the group transactions hoping for the balance to be zero. Nope it did not despite having empty transactions in the group. I can't delete the group as well because i have to "settle balances" first before i can delete.

Screenshot_2024-10-24-13-09-27-798_com android chrome

@KMKoushik
Copy link
Member

yes this is an issue with group expense calculation but it won't actually affect the balance between your friends, if you go to balances page it should be calculated correctly.

this is a problem with group where i don't know which balance get canceled and i recalculate those only on settle up events for hroups.

may be i can handle this for delete event. that being said you don't have to worry about this. once you settle up a payment this will be reset for the group!

@alexanderwassbjer
Copy link
Contributor

I cant really reproduce this bug? Even how many times I have tried to add and remove expenses with multiple people in a group I cant seem to reproduce the issue?

@ptsimon
Copy link
Author

ptsimon commented Oct 28, 2024 via email

@alexanderwassbjer
Copy link
Contributor

@ptsimon Thanks

@KMKoushik I saw that when clicking in the activity tab on an expense its always redirecting to /expenses/id.
If it would redirect to /groups/id/expenses/id in group expense type and /expenses/id on friend expense type, and the delete would be from that page group expense page instead I think it would work with the calculation, or? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants