-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action menu - create settings page #27
Comments
@jossef please throw settings here |
Save the state between browser restarts |
I'm thinking about these settings on a Popup. As a user, I think I expect it to affect the page immediately, means that on a StackOverflow page, when I will disable one of the advisories, I will expect the "issues counters" to withdraw, without refresh. On the other hand, if the setting is in the Oprions page, it will be expected the settings will take effect only after a page refresh. @jossef WDYT? |
If we'll place a copy of those enable/disable settings in our global reactive store, the vue component can filter the disabled ones and ignore em' with immediate reaction. This means we will need to remove the global issues counter and let the vue component calculate it (should be a simple sum) |
Right. So we choose to activate the settings immediately? |
👍 |
First work of #27. In this PR I created the infrastructure for controlling the state of the extension from its popup. See the review comments for specific implementation details. ![tinywow_Recording 2023-04-03 200726_18612307](https://user-images.githubusercontent.com/17686879/229579780-e3326381-9db4-440c-bbed-9a5036070a1b.gif) --------- Co-authored-by: Jossef Harush Kadouri <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: