Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding standards #10

Open
ivanoats opened this issue Mar 26, 2020 · 6 comments
Open

Coding standards #10

ivanoats opened this issue Mar 26, 2020 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@ivanoats
Copy link
Member

  • eslint runs prettier

  • css standard?

  • functional components and hooks over class based components

  • types if possible

  • anything else? comments and questions?

@GarrySan
Copy link

sass instead of css?

@ivanoats
Copy link
Member Author

I don't think Sass is really necessary if we are using a css-in-js system styled components or css modules. It just adds an extra layer of tooling, and extra syntax to learn, in my opinion.

@GarrySan
Copy link

Yup, if we are using material-ui components then most of the styling will be of the css-in-js form, leaving very little components that we will need to style.

@ivanoats
Copy link
Member Author

#19 takes care of most of this. The PR just needs conflicts resolved

@riteshsp2000
Copy link
Contributor

Hey I had resolved the conflicts. But just saw now that other PRs were merged. I'll resolve the conflicts now and then it should be good to review

@ivanoats
Copy link
Member Author

One we add these to https://github.com/orcasound/orcamap-react/blob/main/CONTRIBUTING.md we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants