-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding standards #10
Comments
sass instead of css? |
I don't think Sass is really necessary if we are using a css-in-js system styled components or css modules. It just adds an extra layer of tooling, and extra syntax to learn, in my opinion. |
Yup, if we are using material-ui components then most of the styling will be of the css-in-js form, leaving very little components that we will need to style. |
#19 takes care of most of this. The PR just needs conflicts resolved |
Hey I had resolved the conflicts. But just saw now that other PRs were merged. I'll resolve the conflicts now and then it should be good to review |
One we add these to https://github.com/orcasound/orcamap-react/blob/main/CONTRIBUTING.md we can close this issue. |
eslint runs prettier
css standard?
functional components and hooks over class based components
types if possible
anything else? comments and questions?
The text was updated successfully, but these errors were encountered: