Skip to content
This repository has been archived by the owner on Dec 24, 2020. It is now read-only.

Options Factory takes in OptionsExchange as an input instead of OptionsExchangeAddress #7

Open
aparnakr opened this issue Feb 22, 2020 · 1 comment
Open

Options Factory takes in OptionsExchange as an input instead of OptionsExchangeAddress #7

aparnakr opened this issue Feb 22, 2020 · 1 comment
Labels
Low-Severity

Comments

@aparnakr
Copy link
Contributor

No description provided.

@haythemsellami haythemsellami mentioned this issue Mar 18, 2020
Closed
@epheph
Copy link

epheph commented Jun 4, 2020

the EVM compiler is smart enough to not store contract in bytecode if it is only referenced externally and not deployed from the contract in question. It's preferable to store these things as typed (the way it is currently on master) instead of casting every time you need to call:

https://github.com/opynfinance/Convexity-Protocol/blob/acdaaa36b42e2b68a77a549bc1f1be5eccc94ef7/contracts/OptionsFactory.sol#L18

I recommend closing this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Low-Severity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epheph @aparnakr